Skip to content
  • Thomas Petazzoni's avatar
    lz4: install programs as well as libraries · 2e18e017
    Thomas Petazzoni authored
    Prior to commit 8ad38a4f
    
    
    ("package/lz4: bump version to r131"), the lz4 package was installing
    both libraries and programs, but this commit changed the behavior to
    only install libraries.
    
    The contributor might have been confused by the fact that the build
    command was "$(MAKE) ... -C $(@D) liblz4", suggesting that only the
    library was built. But since the install command was "$(MAKE) ... -C
    $(@D) install", the programs were effectively built as part of the
    install step, and installed as well.
    
    Since it makes sense for lz4 to also installs its programs, this
    commit adjusts the package accordingly.
    
    It is worth mentioning that using the "all" target during the build
    step is important. Indeed, otherwise the programs/Makefile has a
    "default" target that doesn't build everything (especially the lz4c
    program) and it end up being built as part of the install step, due to
    how the makefile dependencies are handled in the lz4 project. To make
    sure that everything gets built during the build step, we explicitly
    use the "all" target.
    
    Fixes bug #9996
    
    Reported-by: default avatarJamin Collins <jamin.collins@gmail.com>
    Initial-analysis-by: default avatarArnout Vandecappelle <arnout@mind.be>
    Signed-off-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
    Signed-off-by: default avatarPeter Korsgaard <peter@korsgaard.com>
    (cherry picked from commit 6f1c11f79a64387c1f1749550804f8aae0cfa7a7)
    Signed-off-by: default avatarPeter Korsgaard <peter@korsgaard.com>
    2e18e017